Code Deodorant

ayyyyyy,

giphy

This week we started using code metrics. We are using codacy which automatically is triggered via a webhook when we commit on our repo, so it does not require Travis at all.

 

Example for a codesmell we fixed:

smell1

This makes sense cause the comparison could throw an exception when sortingOrder null is. To fix this we simply switched the literal with the variable.

Example for a codesmell we will not fix:

smell2

You simply can not delete this method since the OnScrollListener requires this method to be implemented.

When you wanna take a look at our metrics, just stare at the glorious codacy badge on our git repo https://github.com/WowItsSoftwareEngineering/TINF15B4-LSMF/

In our commit history you can see we already removed some of dem smells:

smell3

gReEtZ,

TiNf15B4lSmF

Advertisements

4 thoughts on “Code Deodorant

  1. Hey guys!
    You have done a great job!
    The only think I would like to mention is the missing link to your test file. Of course I could search in your repo for this but I am lazy and it would be great to have a direct link!
    Keep it up!

    Like

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out /  Change )

Google+ photo

You are commenting using your Google+ account. Log Out /  Change )

Twitter picture

You are commenting using your Twitter account. Log Out /  Change )

Facebook photo

You are commenting using your Facebook account. Log Out /  Change )

w

Connecting to %s